dlog validator service: benchmark #1284 #1285
Conversation
adecaro
force-pushed
the
1284-dlog-validator-service-benchmark
branch
4 times, most recently
from
41d63af to
306516e
Compare
Signed-off-by: Angelo De Caro <[email protected]>
adecaro
force-pushed
the
1284-dlog-validator-service-benchmark
branch
from
61b9a21 to
314caa9
Compare
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
| "github.com/hyperledger-labs/fabric-token-sdk/token/core/zkatdlog/nogh/v1/issue/mock" | ||
| v1 "github.com/hyperledger-labs/fabric-token-sdk/token/core/zkatdlog/nogh/v1/setup" | ||
| "github.com/hyperledger-labs/fabric-token-sdk/token/core/zkatdlog/nogh/v1/token" | ||
| benchmark2 "github.com/hyperledger-labs/fabric-token-sdk/token/services/benchmark" |
There was a problem hiding this comment.
there appears to be just one imported benachmark package left here - why isn't it just called "benchmark"?
There was a problem hiding this comment.
it conflicts with a struct name
There was a problem hiding this comment.
why are these keys in the git? wouldn't it be better to create them on the fly as part of the setup of the tests/benchmarks? e.g., that would make the git more stable when the structure of these keys change for some reason.
There was a problem hiding this comment.
to generate them, an external command needs to be invoked.
To generate these keys on the fly, I would need to make sure that the tool is installed and then from Go invoke a shell command. Not obvious.
There was a problem hiding this comment.
what's the difference between the following?
token/core/zkatdlog/nogh/v1/transfer_test.go
token/core/zkatdlog/nogh/v1/transfer/transfer_test.go
There was a problem hiding this comment.
token/core/zkatdlog/nogh/v1/transfer/transfer_test.go: it is related to ZKP + serialization
token/core/zkatdlog/nogh/v1/transfer_test.go is the above plus additional generation of the Token-SDK action.
|
|
||
| func TestValidator(t *testing.T) { | ||
| t.Run("Validator is called correctly with a non-anonymous issue action", func(t *testing.T) { | ||
| configurations, err := benchmark.NewSetupConfigurations("./../testdata", []uint64{testUseCase.Bits}, []math.CurveID{testUseCase.CurveID}) |
There was a problem hiding this comment.
looks like the following 4 lines of code are repeated in many tests here. Consider using some common getter.
Signed-off-by: Angelo De Caro <[email protected]>
This PR does the following: